Fix #68: device row is no longer mistaken for a section header - #74
Merged
Conversation
parseAVDevices ran the section-header Contains test first, so a device whose OS-supplied name contains "AVFoundation audio/video devices:" had its row dropped and the section flipped, misclassifying every device after it — a false no-microphone abort, or a shadowing virtual driver hidden from the roster that exists to expose it. The [N] index, which a real header line never carries, now decides: the deviceLine regex runs first and only a non-device line can switch sections. Fixes #68. Assisted-by: Claude:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validated against main: the header
switchinparseAVDevicesran a whole-linestrings.Containsbefore the device regex, so a crafted device name containing a header phrase dropped its own row and flipped the section (regression test added first — it fails on main withUSB audio CODECmisfiled under video, exactly as the issue describes).Fix: run the
[N]-indexeddeviceLineregex first; only a line that is not a device row can switch sections. CHANGELOG entry added.Fixes #68