Fix #67: install ffprobe in the macOS local-ffmpeg branch - #73
Merged
Conversation
evermeet.cx publishes ffprobe as its own download — the ffmpeg zip never carries it — so the darwin branch installed ffmpeg only, and transcribe -audio's offset derivation silently fell back to 0 on a macOS machine without Homebrew. Extract the fetch/verify/install sequence into install_evermeet_tool and run it for both binaries: ffmpeg failure still skips the branch, ffprobe failure is best-effort, mirroring the Linux ffprobe install. Closes the residual gap round 46's Linux fix recorded. Fixes #67. Assisted-by: Claude:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validated against main: the darwin branch of
install_ffmpeg_localinstalled onlyffmpeg(evermeet publishesffprobeas a separate download), so a macOS-without-Homebrew install lefttranscribe -audioderiving a silent 0 offset — the exact gap round 46's Linux fix recorded as residual.Fix: extract the evermeet fetch/GPG-verify/install sequence into
install_evermeet_tool(same pinned key, same fail-closed verification) and run it forffmpeg(failure skips the branch, as before) andffprobe(best-effort, mirroring the Linux branch's rationale). CHANGELOG entry added.Fixes #67