Add authenticated server identity discovery - #76
Open
Jason-Morcos wants to merge 1 commit into
Open
Conversation
This was referenced Aug 31, 2026
Jason-Morcos
force-pushed
the
codex/authenticated-server-identity
branch
from
August 31, 2026 22:29
5f84f7a to
f8d5c65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the first half of #75.
Why
The two WD53-family appliances I have running locally present a trusted Samsung
hardware certificate during the first manufacturer-certificate session, but
the certificate UUID is not available to the caller before that handshake.
The certificate UUID also has to be treated separately from the OCF device UUID
read from
/oic/d.SamsungServerProfile.bound_device()remains the right profile after thatbinding has been established. The missing piece was a way to make the initial
authenticated connection without weakening the normal pinned profile.
What changes
SamsungServerProfile.discover_device()for that explicit first-useconnection;
C=KR,O=Samsung Electronics,selected
OUrole checks;verified leaf;
DtlsCoapSession.server_certificate_identityafterconnect()succeeds;learned peer identity; and
/oic/devidence from the same authenticatedsession, then returning to
bound_device()for normal connections.Both client-certificate and server-only certificate providers use the same
profile contract. Existing unprofiled sessions continue to expose
None.This does not perform ownership transfer, write OCF security resources, or
persist the learned association.
Validation
subjects, nil UUID, wrong device role, provider reuse, and both certificate
provider shapes
fail-closed cleanup for missing or malformed post-handshake identity
mainMerge order
This is the first PR in the #75 stack. The HVR-only peer cleanup follows it;
the final public API/documentation pass follows both. #74 is independent.