Model an MFX module as the 135 mm slot that centres it, and add the NTR4 module - #1281
Merged
Merged
Conversation
…dule An MFX module is 134 mm across and its carrier slot 135 mm, and the track's sliding blocks centre the module in the slot. `MFX_DWP_module_flat` is modelled as 134 mm placed at the slot's origin rather than centred in it, so a plate on it sits half a millimetre to the left of where it stands. Modelling the module as the 135 mm its slot is puts a plate centred on the module where it is centred on the slot. On a STAR deck with the carrier at track 30, a plate on that module moves x 755.62 to 756.12. `hamilton_mfx_module_tiprackholder_ntr` (cat. no. 191425) is the NTR4 site, for a stack of up to four 96 nested tip racks, 135 mm across for the same reason. The carrier's height reads 18.2 rather than 18.195 throughout. It cancels between the carrier's site and each module's own height, so nothing on the other three modules moves; on `MFX_DWP_module_flat`, whose height is independent, it is 5 um. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An MFX module is 134 mm across and stands in a 135 mm carrier slot, which the track's sliding blocks centre it in.
MFX_DWP_module_flatis modelled as 134 mm at the slot's origin rather than centred in it, so a plate on it sits 0.5 mm left of where it stands.Modelled as the 135 mm its slot is, a plate centred on the module is centred on the slot.
MFX_DWP_module_flat, MFX carrier at track 30hamilton_mfx_module_tiprackholder_ntr(cat. no. 191425) is the NTR4 site, for a stack of up to four 96 nested tip racks. 135 mm across for the same reason, 94 mm deep from Hamilton's NTR4Module model, 20 mm tall measured.MFX_DWP_module_flat, whose height is independent of it, it is 5 um.MFX_TIP_moduleand make it anEmbeddedTipRackHolder#1275 did.Tests: the NTR module centres an SBS rack over its slot. Full suite 3409 passed, 4 skipped, on pytest 9.0.3 and 9.1.1 both.
make lint,make format-checkandtyposclean.🤖 Generated with Claude Code