Skip to content

fix(dag-viewer): recategorize QueryExpr node kinds against real IR (#187) #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzylol wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(dag-viewer): recategorize QueryExpr node kinds against real IR (#187) #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10dae8a
fix(dag-viewer): recategorize QueryExpr node kinds against real IR (#…
zzylol Aug 26, 2026
8e8ea5b
fix(dag-viewer): close code-review gaps on the #187 node-category fix
zzylol Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ on:
- 'Cargo.toml'
- 'Cargo.lock'
- '.github/workflows/rust.yml'
# crates/types/src/dag_export.rs has a #[cfg(test)] cargo test (issue
# #187) that reads tools/dag-viewer/node-style.js's own source and
# fails if its KIND_CATEGORY table drifts from the real DagNode.kind
# strings — a JS-only edit to that file needs this workflow to
# actually run `cargo test` for that guard to catch drift on the PR
# that introduces it, instead of surfacing later as a confusing
# failure on an unrelated Rust change.
- 'tools/dag-viewer/**'
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
branches: [ main ]
Expand All @@ -16,6 +24,14 @@ on:
- 'Cargo.toml'
- 'Cargo.lock'
- '.github/workflows/rust.yml'
# crates/types/src/dag_export.rs has a #[cfg(test)] cargo test (issue
# #187) that reads tools/dag-viewer/node-style.js's own source and
# fails if its KIND_CATEGORY table drifts from the real DagNode.kind
# strings — a JS-only edit to that file needs this workflow to
# actually run `cargo test` for that guard to catch drift on the PR
# that introduces it, instead of surfacing later as a confusing
# failure on an unrelated Rust change.
- 'tools/dag-viewer/**'
workflow_dispatch:

concurrency:
Expand Down
Loading
Loading