Skip to content

Refactor GANTrainer into a more general base class to replace AdversarialTrainer #8950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e-mny wants to merge 36 commits into
base: dev
Choose a base branch
from
Open

Refactor GANTrainer into a more general base class to replace AdversarialTrainer #8950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
d02da49
Refactor download_url test into TestDownloadUrl class
e-mny Apr 17, 2026
867287e
Merge branch 'dev' into dev
e-mny Apr 17, 2026
6296784
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 17, 2026
8a6b6f6
Enoch Mok <enochmokny@gmail.com>
e-mny Apr 18, 2026
66af964
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 18, 2026
43f508b
Merge branch 'dev' into dev
e-mny Apr 18, 2026
834a8b4
Validate downloaded file integrity and raise ValueError on hash mismatch
e-mny Apr 18, 2026
51a49b0
Validate downloaded file integrity and raise ValueError on hash misma…
e-mny Apr 18, 2026
98ccecc
amended runtimeerrors -> valueerror
e-mny Apr 18, 2026
29ec2fe
fixing code according to coderabbitai
e-mny Apr 18, 2026
606e7ca
addressed bugs and issues raised in previous commit
e-mny Apr 18, 2026
19ce7f6
Merge branch 'dev' into 8832-hashvalueerror
ericspod Apr 19, 2026
88f8372
addressing Eric's comment in https://github.com/Project-MONAI/MONAI/p…
e-mny Apr 20, 2026
e9861d3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 20, 2026
453b238
removing duplicate line
e-mny Apr 20, 2026
64b8e09
removed duplicated tests for download_url. updated existing tests for…
e-mny Apr 20, 2026
096c6d0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 20, 2026
e8e1f4b
Merge branch 'dev' into 8832-hashvalueerror
ericspod Apr 29, 2026
5b0b5f4
Apply suggestions from code review
e-mny Jun 3, 2026
3c61005
removed hash checking in a function that checks for download fails
e-mny Jun 4, 2026
44f4d10
Merge branch 'dev' into 8832-hashvalueerror
e-mny Jun 4, 2026
126fcc3
Merge branch 'dev' into 8832-hashvalueerror
ericspod Jun 22, 2026
8974b4d
added HashCheckError
e-mny Jun 25, 2026
32ebca7
refactor(engines): introduce SingleNetworkTrainer and DualNetworkTrai…
e-mny Jun 25, 2026
b014da5
Merge branch 'dev' into 8498-trainerclassabstraction
e-mny Jun 25, 2026
731e0e2
adding according to coderabbit's suggestions
e-mny Jun 25, 2026
54f5f60
adding according to coderabbit's suggestions
e-mny Jun 25, 2026
142fc1f
Merge branch 'dev' into 8498-trainerclassabstraction
e-mny Jun 27, 2026
b557772
changed python version in conda env back to 3.10: fixes failed format…
e-mny Jun 27, 2026
0e086f1
error mentioned in github-actions: monai/engines/trainer.py:61:23: er…
e-mny Jul 1, 2026
e2bc461
Merge branch 'dev' into 8498-trainerclassabstraction
e-mny Jul 1, 2026
691a60d
Merge branch 'dev' into 8498-trainerclassabstraction
ericspod Jul 11, 2026
37bf90c
Merge branch 'dev' into 8498-trainerclassabstraction
e-mny Aug 22, 2026
92bea3d
addressed hashvaluecheck implementation in docstring; replaced compil…
e-mny Aug 22, 2026
08000fb
Merge branch '8498-trainerclassabstraction' of github.com:e-mny/MONAI…
e-mny Aug 22, 2026
a6d9f93
reverted back to compile instead of _compile
e-mny Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading