Skip to content

Improve CRidley PAL matching - #562

Merged
Antidote merged 1 commit into
mainfrom
codex/pal-ridley
Sep 22, 2026
Merged

Antidote merged 1 commit into
mainfrom
codex/pal-ridley

Conversation

@encounter

Copy link
Copy Markdown
Member

No description provided.

@decomp-dev

decomp-dev Bot commented Sep 22, 2026

Copy link
Copy Markdown

Report for GM8E01_48 (c6f6394 - fee4898)

No changes

Report for GM8E01_01 (c6f6394 - fee4898)

No changes

Report for GM8J01_00 (c6f6394 - fee4898)

📈 Matched code: 15.80% (+0.08%, +2984 bytes)

✅ 1 new match
Unit Item Bytes Before After
main/MetroidPrime/Player/CPlayer CPlayer::CPlayer(TUniqueId, const CTransform4f&, const CAABox&, unsigned int, CVector3f, float, float, float, float, const CMaterialList&) +41 98.63% 100.00%

Report for GM8P01_00 (c6f6394 - fee4898)

📈 Matched code: 72.29% (+1.03%, +40876 bytes)
📈 Matched data: 74.39% (+0.13%, +1100 bytes)

✅ 90 new matches
Unit Item Bytes Before After
main/MetroidPrime/Enemies/CRidley .rodata +1096 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::UpdateBeam(CStateManager&, float) +668 46.19% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::DoUserAnimEvent(CStateManager&, const CInt32POINode&, EUserEventType, float) +619 78.98% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::~CRidley() +540 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::DoubleSnap(CStateManager&, EStateMsg, float) +480 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::Bounce(CStateManager&, EStateMsg, float) +464 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::ChooseStage3Attack(CStateManager&) +436 35.99% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::AcceptScriptMsg(EScriptObjectMessage, TUniqueId, CStateManager&) +408 90.31% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::TurnAround(CStateManager&, EStateMsg, float) +276 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidleyData::~CRidleyData() +268 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::SpotPlayer(CStateManager&, float) +236 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::TooClose(CStateManager&, float) +228 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::Render(const CStateManager&) const +175 72.41% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::CRidley(TUniqueId, const rstl::basic_string<char, rstl::char_traits<char>, rstl::rmemory_allocator>&, const CEntityInfo&, const CTransform4f&, const CModelData&, const CPatternedInfo&, const CActorParameters&, CInputStream&, unsigned int) +164 93.57% 100.00%
main/MetroidPrime/Enemies/CRidley CRidleyData::CRidleyData(CInputStream&, int) +154 80.63% 100.00%
main/MetroidPrime/Cameras/CCameraShakeData CCameraShakeData::EatOldCameraShakerData(CInputStream&) +140 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::InRange(CStateManager&, float) +112 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::LoopedAttack(CStateManager&, EStateMsg, float) +104 95.12% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::PushPlayer(CStateManager&) const +89 68.10% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::ShouldAttack(CStateManager&, float) +88 0.00% 100.00%
main/MetroidPrime/CActorModelParticles CParticleElectric::SetOverrideIPos(const CVector3f&) +84 0.00% 100.00%
main/MetroidPrime/CActorModelParticles CParticleElectric::SetOverrideFPos(const CVector3f&) +84 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::SetupCollisionManagers(CStateManager&) +82 92.89% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::ShouldTaunt(CStateManager&, float) +76 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::Flinch(CStateManager&, EStateMsg, float) +69 71.30% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::Jump(CStateManager&, EStateMsg, float) +57 90.51% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::FacePlayer(CStateManager&, float) +46 71.85% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::TelegraphAttack(CStateManager&, EStateMsg, float) +45 83.12% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::ShouldFire(CStateManager&, float) +44 0.00% 100.00%
main/MetroidPrime/Enemies/CRidley CRidley::AIStage(CStateManager&, float) +44 0.00% 100.00%

...and 60 more new matches

📈 9 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/Enemies/CRidley __sinit_CRidley_cpp +5107 0.00% 84.00%
main/MetroidPrime/Enemies/CRidley .bss +2226 0.00% 85.11%
main/MetroidPrime/Enemies/CRidley .data +1194 0.00% 97.60%
main/MetroidPrime/Enemies/CRidley .sdata2 +208 3.33% 86.89%
main/MetroidPrime/Enemies/CRidley .sdata +114 0.00% 79.55%
main/MetroidPrime/Enemies/CRidley CRidley::Lurk(CStateManager&, EStateMsg, float) +37 94.41% 98.88%
main/MetroidPrime/Player/CPlayer CPlayer::ProcessInput(const CFinalInput&, CStateManager&) +1 99.40% 99.42%
main/MetroidPrime/Enemies/CRidley CRidley::PreRender(CStateManager&, const CFrustumPlanes&) +1 97.48% 97.56%
main/MetroidPrime/CStateManager CStateManager::CreateStandardGameObjects() 0 99.99% 99.99%

Report for GM8E01_00 (c6f6394 - fee4898)

No changes

Report for GM8E01_02 (c6f6394 - fee4898)

No changes

@Antidote
Antidote merged commit 1ca34d7 into main Sep 22, 2026
6 checks passed
@Antidote
Antidote deleted the codex/pal-ridley branch September 22, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants