Skip to content

CAutoMapper: Keep const references to return value - #478

Draft
henriquegemignani wants to merge 1 commit into
mainfrom
feature/auto-mapper-const-references
Draft

henriquegemignani wants to merge 1 commit into
mainfrom
feature/auto-mapper-const-references

Conversation

@henriquegemignani

Copy link
Copy Markdown
Collaborator

No description provided.

@henriquegemignani
henriquegemignani added this pull request to stack #479 September 13, 2026 21:41
@henriquegemignani
henriquegemignani force-pushed the feature/auto-mapper-const-references branch from 5a43040 to 54593f3 Compare September 13, 2026 21:42
Base automatically changed from codex/match-auto-mapper-followup to main September 13, 2026 21:55
@henriquegemignani
henriquegemignani force-pushed the feature/auto-mapper-const-references branch from 54593f3 to a55cc84 Compare September 13, 2026 21:55
@decomp-dev

decomp-dev Bot commented Sep 13, 2026

Copy link
Copy Markdown

Report for GM8E01_01 (d3b4ff4 - a55cc84)

📈 Matched code: 88.78% (+0.04%, +1640 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/MetroidPrime/CAutoMapper CAutoMapper::FindClosestVisibleArea(const CVector3f&, const CUnitVector3f&, const CStateManager&, const IWorld&, const CMapWorldInfo&) const +8 99.22% 100.00%
main/MetroidPrime/CAutoMapper CAutoMapper::FindClosestVisibleWorld(const CVector3f&, const CUnitVector3f&, const CStateManager&) const +7 98.79% 100.00%
main/MetroidPrime/CAutoMapper CAutoMapper::GetAreaPointOfInterest(const CStateManager&, int) const +6 96.32% 100.00%

Report for GM8J01_00 (d3b4ff4 - a55cc84)

No changes

Report for GM8E01_00 (d3b4ff4 - a55cc84)

📈 Matched code: 89.25% (+0.04%, +1640 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/MetroidPrime/CAutoMapper CAutoMapper::FindClosestVisibleArea(const CVector3f&, const CUnitVector3f&, const CStateManager&, const IWorld&, const CMapWorldInfo&) const +8 99.22% 100.00%
main/MetroidPrime/CAutoMapper CAutoMapper::FindClosestVisibleWorld(const CVector3f&, const CUnitVector3f&, const CStateManager&) const +7 98.79% 100.00%
main/MetroidPrime/CAutoMapper CAutoMapper::GetAreaPointOfInterest(const CStateManager&, int) const +6 96.32% 100.00%

Report for GM8P01_00 (d3b4ff4 - a55cc84)

📈 Matched code: 45.01% (+0.00%, +152 bytes)

✅ 1 new match
Unit Item Bytes Before After
main/MetroidPrime/CAutoMapper CAutoMapper::GetAreaPointOfInterest(const CStateManager&, int) const +6 96.32% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/CAutoMapper CAutoMapper::FindClosestVisibleWorld(const CVector3f&, const CUnitVector3f&, const CStateManager&) const +6 98.79% 99.99%
main/MetroidPrime/CAutoMapper CAutoMapper::FindClosestVisibleArea(const CVector3f&, const CUnitVector3f&, const CStateManager&, const IWorld&, const CMapWorldInfo&) const +4 99.34% 99.99%

Report for GM8E01_48 (d3b4ff4 - a55cc84)

No changes

Report for GM8E01_02 (d3b4ff4 - a55cc84)

No changes

@encounter

Copy link
Copy Markdown
Member

I think this is a fake match and the const& behavior is from something else, like being passed to a const& parameter inline

@encounter
encounter marked this pull request as draft September 15, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants