Skip to content

Replace Pester -Pending with -Skip in rule tests #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Draft

Replace Pester -Pending with -Skip in rule tests #2208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bb30f2
Initial plan
Copilot Aug 21, 2026
fea1125
Replace removed Pester -Pending with -Skip in two rule tests
Copilot Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/Rules/UseIdenticalMandatoryParametersForDSC.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Describe "UseIdenticalMandatoryParametersForDSC" {
}

# todo add a test to check one violation per function
It "Should find a violations" -pending {
It "Should find a violations" -skip {
$violations.Count | Should -Be 0
}
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/Rules/UseToExportFieldsInManifest.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Describe "UseManifestExportFields" {
$results[0].Extent.Text | Should -Be "'*'"
}

It "suggests corrections for AliasesToExport with wildcard" -pending:($IsCoreClr) {
It "suggests corrections for AliasesToExport with wildcard" -skip:($IsCoreCLR) {
$violations = Run-PSScriptAnalyzerRule $testManifestBadAliasesWildcardPath
$violationFilepath = Join-path $testManifestPath $testManifestBadAliasesWildcardPath
Test-CorrectionExtent $violationFilepath $violations[0] 1 "'*'" "@('gbar', 'gfoo')"
Expand Down