Add test coverage for order-sensitive ON_ERROR_STOP check - #86
Open
jnasbyupgrade wants to merge 1 commit into
Open
jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
Add tests/updates for pgxntool commit Postgres-Extensions/pgxntool#122 (order-sensitive ON_ERROR_STOP detection in check-test-install-error-stop.sh): - Bare substring grep passed a file that only ever turned ON_ERROR_STOP off; the script now requires an explicit on-value seen in file order. Extend the existing script-logic bats file with the two new cases that distinguish this from the old bare-substring behavior: - on-then-off still passes (a later off doesn't undo an earlier on) - off-only (never explicitly on) fails Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired with Postgres-Extensions/pgxntool#122, which fixes
check-test-install-error-stop.sh'sON_ERROR_STOPdetection to beorder-sensitive instead of a bare substring grep (per maintainer review
feedback on #109:
Postgres-Extensions/pgxntool#109 (comment)).
Extends
test/standard/check-test-install-error-stop-script.batswith thetwo cases that distinguish the fix from the old behavior:
Test plan
bash .claude/skills/test/scripts/run-tests.sh test/standard/check-test-install-error-stop-script.bats— 8/8 pass (6 existing + 2 new).🤖 Generated with Claude Code