Add regression coverage for test/install ordering guarantee - #84
Open
jnasbyupgrade wants to merge 1 commit into
Open
jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
Add tests/updates for pgxntool commit 937bf35 (guarantee test/install/*.sql schedule ordering): - Wraps `TEST_INSTALL_SQL_FILES` in `$(sort ...)` so install files run in guaranteed, locale-independent byte-value order instead of whatever `$(wildcard)`/`glob()` happens to return - Documents the ordering guarantee and the numeric-prefix convention for inter-file dependencies in `README.asc` New test in test/standard/test-test-install.bats creates install files out of sorted order and asserts the generated schedule lists them correctly, plus a direct check that base.mk actually wires `TEST_INSTALL_SQL_FILES` through `$(sort ...)` -- this container's libc `glob()` already returns sorted results by default, so the schedule-order assertion alone can't distinguish the fix from a revert here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#120
Adds coverage for pgxntool wrapping
TEST_INSTALL_SQL_FILESin$(sort ...), sotest/install/*.sqlfiles run in guaranteed, locale-independent byte-value order instead of whatever$(wildcard)/glob()happens to return (Fixes pgxntool#111).New test in
test/standard/test-test-install.batscreates install files out of sorted order and asserts the generated schedule lists them correctly anyway, plus a direct check thatbase.mkactually wiresTEST_INSTALL_SQL_FILESthrough$(sort ...)-- this container's libcglob()already returns sorted results by default, so the schedule-order assertion alone can't distinguish the fix from a revert here.