test(e2e): add visitor invite coverage for workplace - #492
Draft
sharmilaseenivasan17 wants to merge 1 commit into
Draft
sharmilaseenivasan17 wants to merge 1 commit into
sharmilaseenivasan17 wants to merge 1 commit into
Conversation
23 tests across 11 spec files, mirroring the existing desk coverage: invite (single and group), cancel from the app, form validation, settings, visitor details, times, booking for a colleague, check-in/check-out, editing, and visibility between users. 22 pass; 1 is fixme, blocked on an app bug where saving an edit in single-visitor mode throws and sends nothing. Visitor support code lives in e2e/support/visitor/ so the desk specs cannot be affected - no shared support file is changed. Also adds e2e/tsconfig.json and a bun run e2e:typecheck script; nothing type-checked the specs before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
sharmilaseenivasan17
marked this pull request as draft
September 15, 2026 06:36
sharmilaseenivasan17
force-pushed
the
automated-testing
branch
from
September 16, 2026 08:47
b2dfe8d to
dcbd667
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visitor-invite coverage for the workplace app, alongside the existing desk
specs. Today's work (rooms, Your Bookings, the desk gaps and parking) is a
separate PR, #494, stacked on this branch.
23 tests. 22 passing, 1 blocked on an app defect, 0 failing.
Coverage rows are in
E2E_USER_STORIES.md§1a (VIS-01 … VIS-23); the workinghandover is
e2e/VISITOR_E2E_HANDOVER.md.What is covered
Invite one visitor · invite several · cancel from the app · decline the cancel ·
another user cannot see or delete yours, with a control · a bad email address is
refused before anything is sent · a visitor removed before sending is not
invited · all-day invites · a required reason · pass number and the
international flag · company and the guest record · the chosen start time and
length · limits on what the form offers · booking for a colleague, as host and
as booker · the Associate badge on both schedules · check in and back out · too
early refused by both the app and the API · editing a future-dated delegated
invite · removing one person from a group.
Findings — seven, none filed
_.toJSON is not a functionand sends nothing — the user sees only that raw string. Multi-visitor mode, the shipped default, is fine. This is the one blocked test.${host}[${date created}], so every group invite that host makes that day shares one asset id and the backend rightly refuses the overlap.visitors.can_book_for_anyonerenders the host picker, but the choice is only kept ifvisitors.can_book_for_othersis also set. One without the other silently discards the host — no error, no clue.GET /bookingsdefaults tolimit=100and the schedule sendsinclude_deleted=true, so past 100 soft-deleted bookings a user stops seeing new ones.?booking=<id>never opens the details modal:booking-card.component.tschecksparams.has('booking')then compares the id againstparams.get('event'), a parameter that is not there.bookings.allowed_daily_visitor_countis never read anywhere in this repo.Reproducers for the first three live in
e2e/support/repro/.Structure
Visitor support code is in
e2e/support/visitor/, deliberately separate frome2e/support/{env,api,flows}.tsso nothing visitor-shaped can break the deskspecs —
git diffon those three files is empty.e2e/tsconfig.jsonand abun run e2e:typecheckscript are new; nothing type-checked the specs before.Running it
Before this is merged, please read this
Stale bookings. Each run leaves soft-deleted rows behind, and past 100 per
user the card-dependent specs break in a way that looks nothing like the cause.
It needs either a backend change or a purge step before this suite goes near CI,
and it is an environment decision rather than a spec change.
🤖 Generated with Claude Code