Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
queueSessionEventhelper (inutils.ts) that buffers player events for paused, resumable sessions with a hard cap of 500 events using drop-oldest semantics, so the newest state survives for replay on resume. Warns at 50% capacity and when the cap is reached.clearSessionEventQueuehelper that drains the queue and logs the discarded count; used on session destroy and after the resume flush.emitEventand the main-processplayerEventIPC dispatcher) through the helper, removing duplicated raw push logic.resumingflag (passed throughplayerManagervia the playbackSessiontype), so events are dropped instead of buffered when resuming is disabled, consistent with the dispatcher behavior.SessionManager.pause()now clears any staletimeoutFuturebefore scheduling a new destroy timer, preventing leaked handles and premature session destruction on pause/resume cycles.Why
Checkmarks
Additional info
The cap value (500) is intentionally conservative; each buffered event is a serialized JSON string, so worst-case memory per paused session stays in the low hundreds of KB.