fix: wire setDucking into PlayerManager - #239
Merged
Merged
Conversation
1Lucas1apk
requested changes
Sep 15, 2026
1Lucas1apk
left a comment
1Lucas1apk
left a comment
Member
There was a problem hiding this comment.
Could you run "npm run build" (or "npx tsc") before merging this?
It looks like the generated output hasn't been updated yet. Since we keep "dist" tracked in the repository, we should make sure the compiled files are in sync with the source changes.
Other than that, LGTM!
setDucking was declared in the route interface and already implemented on Player, but PlayerManager never got the bridging method, so toggling ducking crashed with a 500
Contributor
Author
thanks for the review, fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PlayerManagergets the missingsetDucking(guildId, enabled)bridge, mirroringsetLoudnessNormalizer, routes torunClusterMutationwhen clustered, otherwise resolves the local player and forwards toplayer.setDucking(enabled)Why
setDuckingwas already declared on the route interfaces (sessions.id.players.ts,sessions.id.groups.ts) and implemented onPlayer, butPlayerManagernever got the bridging method, sosession.players.setDucking(...)didn't exist and toggling ducking crashed with a 500 on both endpointsCheckmarks
Additional information
tsc passes