Skip to content

improve: reuse route planner ip block entry type - #238

Merged
1Lucas1apk merged 2 commits into
PerformanC:devfrom
snakkeeh:dev
Sep 15, 2026
Merged

1Lucas1apk merged 2 commits into
PerformanC:devfrom
snakkeeh:dev

Conversation

@snakkeeh

Copy link
Copy Markdown
Contributor

Changes

  • Reuse shared RoutePlannerIpBlockEntry type in routePlannerManager.ts, config.types.ts, and player.types.ts instead of three duplicated inline unions. Single source of truth stays in src/typings/api/routeplanner.types.ts.
  • Fix betwenn typo in TV.ts and TV_downgraded.ts player-params comments.

Why

Follow-up to #237: the shared entry type introduced there was only used by the status endpoint. Reusing it in the manager and config types keeps all route planner ipBlocks shapes consistent, and folding in the tiny comment typo fix avoids a noise-only PR.

Checkmarks

  • The modified endpoints have been tested.
  • Used the same indentation as the rest of the project.
  • Still compatible with LavaLink clients.

Additional information

Type-only change plus comment-only typo fix; no runtime behavior changed. Verified routeplanner.ts + routePlannerManager.ts still import cleanly with node --experimental-strip-types.

@1Lucas1apk
1Lucas1apk merged commit fe13c91 into PerformanC:dev Sep 15, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants