Skip to content

Fix Conjoined Spire AoE calc #10301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaisest wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix Conjoined Spire AoE calc #10301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feeab62
Fix Conjoined Spire AoE calc
vaisest Aug 27, 2026
0797a2b
Test
vaisest Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions spec/System/TestOffence_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,4 +352,17 @@ describe("TestOffence", function()
assert.are.equals(1, build.calcsTab.mainOutput[outputName])
end)
end
it("uses the final totem limit when scaling area of effect", function()
build.skillsTab:PasteSocketGroup("Searing Bond of Detonation 20/0 1")
build.configTab.input.customMods = [[
+3 to Maximum Power Charges
Skills used by Totems have 10% more Area of Effect per maximum number of Summoned Totems
]]
build.configTab:BuildModList()
runCallback("OnFrame")

-- 1 base totem + 6 maximum power charges, so 70% more area of effect.
assert.are.equals(7, build.calcsTab.mainOutput.ActiveTotemLimit)
assert.are.equals(1.7, build.calcsTab.mainOutput.AreaOfEffectMod)
end)
end)
4 changes: 4 additions & 0 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,10 @@ function calcs.offence(env, actor, activeSkill)
end
end
if skillFlags.area or skillData.radius or (skillFlags.mine and activeSkill.skillTypes[SkillType.Aura]) then
-- add totem limit output early for conjoined spire
if skillFlags.totem then
output.ActiveTotemLimit = skillModList:Sum("BASE", skillCfg, "ActiveTotemLimit", "ActiveBallistaLimit")
end
calcAreaOfEffect(skillModList, skillCfg, skillData, skillFlags, output, breakdown)
end
if activeSkill.skillTypes[SkillType.Aura] then
Expand Down
Loading