Skip to content

Fix Mana-Infused Staff incorrectly working if reserving Life - #10283

Merged
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
cupkax:fix-mana-infused-staff-arrogance-interaction
Aug 26, 2026
Merged

Fix Mana-Infused Staff incorrectly working if reserving Life#10283
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
cupkax:fix-mana-infused-staff-arrogance-interaction

Conversation

@cupkax

@cupkax cupkax commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #10273.

Description of the problem being solved:

Mana-infused does not allow life reservation. In-game the gem can be supported by arrogance but is not functional. Secondly, if the player allocates blood magic, the game turns the gem inactive with no available mana error.

PoB currently allows life reservation for mana-infused staff. This PR prevents life-reservation on the gem and only turns it active if mana can be reserved. I've hard-coded the arrogance support guard to prevent specific hungry loop interaction (probably a better way to fix that).

Steps taken to verify a working solution:

  • Equipped Mana-infused staff and arrogance.
  • Equip both blood magic and mana-infused staff

Link to a build that showcases this PR:

Before screenshot:

639894655-d6ff6c06-7eb6-4e35-94b2-de83ebfc3fc9

After screenshot:

image image

@LocalIdentity
LocalIdentity merged commit a0fade7 into PathOfBuildingCommunity:dev Aug 26, 2026
2 of 3 checks passed
@LocalIdentity LocalIdentity changed the title Fix Mana-infused staff allowing life reservation Fix Mana-Infused Staff incorrectly working if reserving Life Aug 26, 2026
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Aug 26, 2026
@mcagnion

Copy link
Copy Markdown
Contributor

Mana-Infused Staff is disabled correctly when Blood Magic leaves the character with no mana, but the reservation pass adds its forced 30% mana reservation before setting the disabled flag. In that reachable setup, reserved_ManaPercent remains 30 and the Mana Reserved breakdown still lists Mana-Infused Staff even though the skill is disabled and the final mana reservation outputs are empty.

A focused headless reproduction also confirms that weapon-set recalculation clears and rebuilds this state, so the defect is limited to the current zero-mana calculation pass rather than persistent state. The disable path should avoid leaving the skill’s aggregate and breakdown entry behind.

AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.

@cupkax
cupkax deleted the fix-mana-infused-staff-arrogance-interaction branch August 27, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mana-infused staff linked with Arrogance

3 participants