Fix Mana-Infused Staff incorrectly working if reserving Life - #10283
Conversation
a0fade7
into
PathOfBuildingCommunity:dev
|
Mana-Infused Staff is disabled correctly when Blood Magic leaves the character with no mana, but the reservation pass adds its forced 30% mana reservation before setting the disabled flag. In that reachable setup, A focused headless reproduction also confirms that weapon-set recalculation clears and rebuilds this state, so the defect is limited to the current zero-mana calculation pass rather than persistent state. The disable path should avoid leaving the skill’s aggregate and breakdown entry behind. AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction. |
Fixes #10273.
Description of the problem being solved:
Mana-infused does not allow life reservation. In-game the gem can be supported by arrogance but is not functional. Secondly, if the player allocates blood magic, the game turns the gem inactive with
no available manaerror.PoB currently allows life reservation for mana-infused staff. This PR prevents life-reservation on the gem and only turns it active if mana can be reserved. I've hard-coded the arrogance support guard to prevent specific hungry loop interaction (probably a better way to fix that).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: