Port PoB1 #9861 type hint PR - #2414
Merged
LocalIdentity merged 8 commits intoAug 26, 2026
Merged
Conversation
vaisest
marked this pull request as ready for review
August 14, 2026 14:25
# Conflicts: # src/Modules/Common.lua
LocalIdentity
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Ports PathOfBuildingCommunity/PathOfBuilding#9861
The newClass() transformations were done with a claude code script. I wasn't able to find any errors in it, and I'd trust there to be none as the robot was rather exact about any differences since they could be compared directly with the pob1 versions. The rest were done by hand or by regex
Boss config related data seems to have been removed from the game or something. I left the files as is and skipped the script with a goto. This should probably be fixed in a latter pr if possible
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: