chore: bump the patch group across 1 directory with 2 updates - #6203
chore: bump the patch group across 1 directory with 2 updates#6203dependabot[bot] wants to merge 1 commit into
Conversation
prql-bot
left a comment
There was a problem hiding this comment.
Holding approval: this lockfile bump raises the effective MSRV above the project's declared 1.81.0, and test-msrv has already failed on this commit (job). It isn't fixable by pinning within the bump — the choice is a maintainer call, so I haven't pushed anything.
The chain: mdbook-core 0.5.4 requires toml ^1.1.2 (0.5.2 needed toml 0.9), toml 1.1.4 requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 — 2.14.0, the version this lock selects, declares 1.85. indexmap is a normal (not dev-only) dependency of prqlc via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml.
Two ways forward, both outside what I'd change unilaterally on a Dependabot branch:
- Raise the MSRV —
rust-versionin the workspaceCargo.tomlandmetadata.msrvinprqlc/prqlc/Cargo.toml, to 1.85. That's an outward compatibility change for downstreamprqlcusers, so it belongs in its own PR that this one rebases onto rather than folded in here. - Skip the mdbook bump — keep 0.5.2. Worth noting 0.5.4 declares
rust-version = "1.88.0"itself, so it will keep colliding with the MSRV until the first option happens; a Dependabot ignore entry would stop the PR recurring.
Happy to open either as a separate PR if you say which.
Also worth flagging while the MSRV question is open: mdbook-prql doesn't set rust-version.workspace = true, so nothing gates mdbook-core's own 1.88 requirement today — but it does mean the book preprocessor can no longer be built on the toolchain the project advertises as its minimum.
Verification notes
Diff is Cargo.lock only (104 lines) — mdbook-core/mdbook-preprocessor 0.5.2 → 0.5.4, plus the transitive re-resolution: indexmap 2.11.4 → 2.14.0, hashbrown 0.17.1 added, toml 0.9.12 → 1.1.4, toml_datetime 1.1.1 added alongside 0.7.5, winnow 1.0.3. web/book/Cargo.toml still requests 0.5.2, which ^0.5.2 satisfies — no manifest change needed.
MSRV data from the crates.io sparse index (indexmap):
2.11.4 rust_version=1.63 <- base
2.12.0 rust_version=1.82
2.13.1 rust_version=1.82
2.14.0 rust_version=1.85 <- this PR
So no pin inside toml ^1.1.2's indexmap ^2.13.0 range restores 1.81 compatibility.
Dependency path confirming indexmap is MSRV-relevant for prqlc (cargo tree -p prqlc -i indexmap):
indexmap v2.14.0
├── serde_yaml v0.9.34+deprecated
│ ├── prqlc v0.13.15
│ └── prqlc-parser v0.13.15
└── toml_edit v0.23.5
└── ... rstest v0.26.1 [dev-dependencies]
test-msrv passed on the merge base (63ffb4ac, run 32022533099) and failed here in 27s at the Verify minimum rust version — prqlc step — consistent with cargo's resolve-time rust-version gate rather than a compile error. The step log wasn't retrievable while the run is still in progress, so the specific error text is inferred from that timing plus the version data above; the failure itself and its attribution to this lockfile are verified.
The check-ok-to-merge failure is a separate matter — it comes from run 32056771137, which was cancelled and superseded by 32056772188; ignore it. The remaining checks on this commit are still queued or running.
Bumps the patch group with 2 updates in the / directory: [mdbook-core](https://github.com/rust-lang/mdBook) and [mdbook-preprocessor](https://github.com/rust-lang/mdBook). Updates `mdbook-core` from 0.5.2 to 0.5.4 - [Release notes](https://github.com/rust-lang/mdBook/releases) - [Changelog](https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md) - [Commits](rust-lang/mdBook@v0.5.2...v0.5.4) Updates `mdbook-preprocessor` from 0.5.2 to 0.5.4 - [Release notes](https://github.com/rust-lang/mdBook/releases) - [Changelog](https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md) - [Commits](rust-lang/mdBook@v0.5.2...v0.5.4) --- updated-dependencies: - dependency-name: mdbook-core dependency-version: 0.5.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch - dependency-name: mdbook-preprocessor dependency-version: 0.5.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch ... Signed-off-by: dependabot[bot] <support@github.com>
e7ab18d to
992cf26
Compare
Bumps the patch group with 2 updates in the / directory: mdbook-core and mdbook-preprocessor.
Updates
mdbook-corefrom 0.5.2 to 0.5.4Release notes
Sourced from mdbook-core's releases.
Changelog
Sourced from mdbook-core's changelog.
... (truncated)
Commits
2ea30c0Merge pull request #3155 from ehuss/bump-versiona08ba2bBump version to 0.5.40e5ddf6Merge pull request #3154 from ehuss/ci-version-stringf4ddbffShow the correct version in CI install docs8b53f1bMerge pull request #3127 from GuillaumeGomez/zoom-inbeab2faMention zoom-in feature in mdbook guide588066cMake the "zoom in" feature work with keyboard and simplify DOMf526b18Only enable "zoom-in" feature on images not inside links73d6edfAdd possibility to "zoom out" using the escape key6a7ef4dAdd regression test for the "zoom-in" featureUpdates
mdbook-preprocessorfrom 0.5.2 to 0.5.4Release notes
Sourced from mdbook-preprocessor's releases.
Changelog
Sourced from mdbook-preprocessor's changelog.
... (truncated)
Commits
2ea30c0Merge pull request #3155 from ehuss/bump-versiona08ba2bBump version to 0.5.40e5ddf6Merge pull request #3154 from ehuss/ci-version-stringf4ddbffShow the correct version in CI install docs8b53f1bMerge pull request #3127 from GuillaumeGomez/zoom-inbeab2faMention zoom-in feature in mdbook guide588066cMake the "zoom in" feature work with keyboard and simplify DOMf526b18Only enable "zoom-in" feature on images not inside links73d6edfAdd possibility to "zoom out" using the escape key6a7ef4dAdd regression test for the "zoom-in" feature