Apply the second megamenu feedback round (develop) - #228
Open
mlaetitia wants to merge 2 commits into
Open
Conversation
… 16:9 featured image, dropdown chevrons, and an instant hide for the outgoing panel Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lai9Z4rVugeJpe4a9gR1s1
…n chevron, and stop the panel switch and mobile close from flickering Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
Member
|
Thanks @mlaetitia for handling the column order. Have a wonderful weekend ahead of you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Proposed changes
--megamenu-trackscustom property per panel and the stylesheet places the items.object-fit: cover.Why are these changes being made?
Second round of partner feedback on the mega menu. Five of the six items were code; the sixth, making Get Involved persistent in the mobile menu, is a menu setting and needed no change.
The column order was the substantive one. CSS grid cannot fill column one before column two without knowing the row count, and letting the featured card imply it made the card's height drive every row. The walker counts each panel's children once and hands the count to CSS, which keeps the layout in the stylesheet rather than stamping coordinates onto every list item.
Two flickers surfaced while testing. On desktop, hiding the outgoing panel instantly while the incoming one still faded in left roughly 200ms with the page showing through; both sides are now instant. On mobile, #227 gave the logo a
z-indexscoped to the open-menu class, but the panel keeps painting for 300ms after that class is dropped, so the fading panel covered the logo. The logo now holds its stacking context unconditionally.Testing instructions
Above 1200px:
Below 1200px:
Worth a pass in Safari and Firefox: the chevron uses a CSS mask, and the panel layout uses a custom property in
repeat().