feat(wtsite): allow an edit comment on upload_page - #151
Open
LukasGold wants to merge 1 commit into
Open
Conversation
- add comment field to WtSite.UploadPageParam - forward it to WtPage.edit, which already accepted one - closes #112
Contributor
Release previewMerging this PR would release v2.1.0 (current: Changelog preview (truncated)## v2.1.0 (2026-09-01)
### Features
- **wtsite**: Allow an edit comment on upload_page
([`0d3899c`](https://github.com/OpenSemanticLab/osw-python/commit/0d3899c782998c5750338dc11beea569207cb26c))
### Testing
- Rename oold.py to oold_test.py so its tests are collected
([`20072a9`](https://github.com/OpenSemanticLab/osw-python/commit/20072a9249cd97126a222c62a70f84e0433343ef))
Preview via python-semantic-release and conventional commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112
Changes
WtSite.UploadPageParamgains acommentfield, mirroring the one onCopyPagesParamupload_pageforwards it toWtPage.edit, which has accepted a comment all alongtests/test_wtsite_upload_page.py: comment reaches a single page, reaches every page of a batch, and defaults toNoneRationale
WtPage.edit(comment=...)already existed, butupload_pagecalled a barepage.edit(), so bulk uploads landed in the page history unattributed with no way to pass a summary short of editing each page directly.Default behaviour is unchanged: with no comment set,
edit(None)is exactly the previous call.