test(spp_drims): assert SLA coverage over the canonical priority codes only (#443)

spp_drims/README.rst

@@ -179,6 +179,15 @@ Dependencies
 Changelog
 =========
 
+19.0.4.0.5
+~~~~~~~~~~
+
+- fix(tests): the SLA completeness test now checks only the priority
+  codes spp_drims itself ships. It compared against every code in the
+  vocabulary, so installing an overlay that legitimately extends
+  priorities — spp_drims_sl adds life_threatening — made the exact-match
+  assertion fail on a fourth key the module never claimed to cover
+
 19.0.4.0.4
 ~~~~~~~~~~
 

spp_drims/__manifest__.py

@@ -5,7 +5,7 @@
     "and distribution tracking. Links to hazard incidents with multi-tier "
     "approval workflows and warehouse operations.",
     "category": "OpenSPP/Inventory",
-    "version": "19.0.4.0.4",
+    "version": "19.0.4.0.5",
     "sequence": 1,
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",

spp_drims/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.4.0.5
+
+- fix(tests): the SLA completeness test now checks only the priority codes spp_drims itself ships. It compared against every code in the vocabulary, so installing an overlay that legitimately extends priorities — spp_drims_sl adds life_threatening — made the exact-match assertion fail on a fourth key the module never claimed to cover
+
 ### 19.0.4.0.4
 
 - fix(drims): name constants after codes the vocabulary actually ships, and fix the three places that used the wrong ones. An urgent request answered a 24-hour approval SLA instead of 8 hours, the priority badge and list decorations never fired, and the High Priority search filter always returned nothing — all because the code asked for priorities the data does not contain. A test now walks every code constant against its vocabulary, so one naming a code that does not exist fails the build instead of silently matching nothing (#1165)

spp_drims/static/description/index.html

@@ -565,6 +565,16 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
 </div>
 </div>
 <div class="section" id="section-1">
+<h1>19.0.4.0.5</h1>
+<ul class="simple">
+<li>fix(tests): the SLA completeness test now checks only the priority
+codes spp_drims itself ships. It compared against every code in the
+vocabulary, so installing an overlay that legitimately extends
+priorities — spp_drims_sl adds life_threatening — made the exact-match
+assertion fail on a fourth key the module never claimed to cover</li>
+</ul>
+</div>
+<div class="section" id="section-2">
 <h1>19.0.4.0.4</h1>
 <ul class="simple">
 <li>fix(drims): name constants after codes the vocabulary actually ships,
@@ -577,7 +587,7 @@ <h1>19.0.4.0.4</h1>
 the build instead of silently matching nothing (#1165)</li>
 </ul>
 </div>
-<div class="section" id="section-2">
+<div class="section" id="section-3">
 <h1>19.0.4.0.3</h1>
 <ul class="simple">
 <li>fix(drims): show only the states a dispatch can reach on its status
@@ -587,7 +597,7 @@ <h1>19.0.4.0.3</h1>
 shows when a dispatch is actually in it (#1086)</li>
 </ul>
 </div>
-<div class="section" id="section-3">
+<div class="section" id="section-4">
 <h1>19.0.4.0.2</h1>
 <ul class="simple">
 <li>feat(drims): confirm a delivery through a popup rather than the
@@ -597,7 +607,7 @@ <h1>19.0.4.0.2</h1>
 reflects what was received rather than what was sent (#1088)</li>
 </ul>
 </div>
-<div class="section" id="section-4">
+<div class="section" id="section-5">
 <h1>19.0.4.0.1</h1>
 <ul class="simple">
 <li>fix(drims): only let a dispatch ship what its request approved.
@@ -607,7 +617,7 @@ <h1>19.0.4.0.1</h1>
 and delete affordances hidden to match (#1057)</li>
 </ul>
 </div>
-<div class="section" id="section-5">
+<div class="section" id="section-6">
 <h1>19.0.4.0.0</h1>
 <ul class="simple">
 <li>feat(drims): Donations review — creation, receipt, inspection and
@@ -627,7 +637,7 @@ <h1>19.0.4.0.0</h1>
 but no longer readable through the ORM or shown in any view (#1076)</li>
 </ul>
 </div>
-<div class="section" id="section-6">
+<div class="section" id="section-7">
 <h1>19.0.3.1.0</h1>
 <ul class="simple">
 <li>feat(drims): Incident Management review — incidents are entered as a
@@ -644,7 +654,7 @@ <h1>19.0.3.1.0</h1>
 refresh cron skips (#1100)</li>
 </ul>
 </div>
-<div class="section" id="section-7">
+<div class="section" id="section-8">
 <h1>19.0.3.0.4</h1>
 <ul class="simple">
 <li>feat(drims): rework the dispatch page and correct the waybill.
@@ -664,7 +674,7 @@ <h1>19.0.3.0.4</h1>
 barcode (#1151)</li>
 </ul>
 </div>
-<div class="section" id="section-8">
+<div class="section" id="section-9">
 <h1>19.0.3.0.1</h1>
 <ul class="simple">
 <li>fix(drims): a dispatch validated short no longer leaves the request
@@ -676,7 +686,7 @@ <h1>19.0.3.0.1</h1>
 API (#1087)</li>
 </ul>
 </div>
-<div class="section" id="section-9">
+<div class="section" id="section-10">
 <h1>19.0.3.0.0</h1>
 <ul class="simple">
 <li>feat(drims): allocate stock per source warehouse. The Allocate Stock
@@ -696,7 +706,7 @@ <h1>19.0.3.0.0</h1>
 destination-type selector (#1075)</li>
 </ul>
 </div>
-<div class="section" id="section-10">
+<div class="section" id="section-11">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_drims/tests/test_constants.py

@@ -192,7 +192,7 @@ def test_sla_hours_are_keyed_by_real_priority_codes(self):
         whole failure mode OP#1165 is about.
         """
         settings = self.env["res.config.settings"]
-        codes = self._codes_in(constants.VOCAB_PRIORITY_LEVELS)
+        codes = self._canonical_codes_in(constants.VOCAB_PRIORITY_LEVELS)
 
         hours = {code: settings.get_approval_sla_hours(code) for code in codes}
         self.assertEqual(