feat!: support roles assignments - #240
Open
typed-sigterm wants to merge 1 commit into
Open
typed-sigterm wants to merge 1 commit into
typed-sigterm wants to merge 1 commit into
Conversation
mxmehl
self-requested a review
August 12, 2026 13:57
Member
|
Thanks for proposing this. To be honest, I am a bit hesitant towards adding manual REST API calls, but would prefrer using PyGithub as much as possible. This is why I proposed adding this to upstream in PyGithub/PyGithub#3578 Regarding your PR, I didn't have time for a thorough review yet, but you may want to check if we have the slug of all teams when we operate with the organization roles, especially if we create a new team and directly add an org role to it. Also, it'd be great if you could rebase and fix the small lint issues. But provided we get the org roles features into pygithub soon, it might make sense to wait for that to be released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #95. Tested with my org.
It might be a breaking change because someone may already manually assigned roles, but the existng assignments will be removed if they're not in config.