Skip to content

Fix ORs acting as ANDs in a TrackPieces validation check #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeftofZen merged 2 commits into from
Sep 21, 2026
Merged

Fix ORs acting as ANDs in a TrackPieces validation check #277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6785ce5
Update TrackObject.cs
LeeSpork Sep 18, 2026
5036933
Update TrackObject.cs
LeeSpork Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Definitions/ObjectModels/Objects/Track/TrackObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ public IEnumerable<ValidationResult> Validate(ValidationContext validationContex
yield return new ValidationResult($"{nameof(TunnelCostFactor)} must be positive.", [nameof(TunnelCostFactor)]);
}

if (TrackPieces.HasFlag(TrackTraitFlags.Diagonal | TrackTraitFlags.LargeCurve) && TrackPieces.HasFlag(TrackTraitFlags.OneSided | TrackTraitFlags.VerySmallCurve))
if ((TrackPieces.HasFlag(TrackTraitFlags.Diagonal) || TrackPieces.HasFlag(TrackTraitFlags.LargeCurve)) && (TrackPieces.HasFlag(TrackTraitFlags.OneSided) || TrackPieces.HasFlag(TrackTraitFlags.VerySmallCurve))
{
yield return new ValidationResult($"{nameof(TrackPieces)} cannot include both {TrackTraitFlags.Diagonal} or {TrackTraitFlags.LargeCurve} and {TrackTraitFlags.OneSided} or {TrackTraitFlags.VerySmallCurve}.", [nameof(TrackPieces)]);
yield return new ValidationResult($"{nameof(TrackPieces)} cannot include {TrackTraitFlags.Diagonal} or {TrackTraitFlags.LargeCurve} if it also includes {TrackTraitFlags.OneSided} or {TrackTraitFlags.VerySmallCurve}.", [nameof(TrackPieces)]);
}

if (Bridges.Count > 7)
Expand Down