docs: document the identity contract of the serializer constant labels - #1898
Open
velo wants to merge 1 commit into
Open
docs: document the identity contract of the serializer constant labels#1898velo wants to merge 1 commit into
velo wants to merge 1 commit into
Conversation
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only, no behaviour change.
SerializerBase.constantToLabelis anIdentityHashMapkeyed on arbitraryconstants supplied by the caller, and
getConstantToLabel()exposes it as publicAPI. Nothing said so, which matters in two directions:
serializeConstantto bind by label depends onthe identity keying; one that binds positionally (JPA and SQL both do) does not.
preview in JDK 28) migrates the primitive wrappers and
LocalDateto valueclasses, at which point
==andidentityHashCodebecome state-based and themap starts collapsing equal-but-distinct constants onto one label.
Added javadoc on the field and the accessor recording both, and pointed at
SerializerBaseTest, which pins the current behaviour.🤖 Generated with Claude Code
https://claude.ai/code/session_01WnNBe1GoG2SxfU3FN7bcAA