Fix missing regularization core on mirrored FVW segments (ShearModel=1) - #3472
Merged
Merged
Conversation
In PackPanelsToSegments, the ground-mirror block reflected segment points and negated circulation but never assigned SegEpsilon for the mirrored half. The image segments therefore kept the -999999 sentinel core size from allocation, which silently disabled or corrupted their Biot-Savart contribution (segment/particle kernels collapse to ~0 for a negative core, and the treecode MAC floor degenerates), so ground effect under ShearModel=1 was under-delivered rather than crashing. Copy the regularization core from each real segment to its image (SegEpsilon(iMirror) = SegEpsilon(i)), which is physically exact since an image vortex shares the core size of its source. Co-authored-by: GitHub Copilot <copilot@github.com> Co-authored-by: Claude <noreply@anthropic.com>
andrew-platt
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
In
PackPanelsToSegments, the ground-mirror block reflected segment points and negated circulation but never assignedSegEpsilonfor the mirrored half. The image segments therefore kept the -999999 sentinel core size from allocation, which silently disabled or corrupted their Biot-Savart contribution (segment/particle kernels collapse to ~0 for a negative core, and the treecode MAC floor degenerates), so ground effect underShearModel=1was under-delivered rather than crashing.Copy the regularization core from each real segment to its image (
SegEpsilon(iMirror) = SegEpsilon(i)), which is physically exact since an image vortex shares the core size of its source.Related issue, if one exists
None
Impacted areas of the software
OLAF
Generative AI usage
Co-authored-by: Anthropic Claude claude@anthropic.com
Assisted by: GitHub Copilot support@github.com
Test results, if applicable
Pending r-test run