Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
In the current OLAF version,
WriteVTKOutputssubroutine inFVW.f90loops over each requested grid and callsInducedVelocitiesAll_OnGrid. This routine rebuilds the entire induction data from scratch on every call. Basically, OLAF (i) takes every vortex panel and converts them to segments, (ii) those segments are then converted into particles, and (iii) finally the induction tree is built to evaluate the induced velocity at the actual grid points. Since this calculation is the same for every grid except for the evaluation at the actual grid points, the data could be reused, making this process much more efficient.The code itself acknowledges this inefficiency in
FVW.f90:! Compute induced velocity on grid, TODO use the same Tree for all CalcOutputExample of 6 grids (VTK outputs) requested in OLAF:
The proposed changes improve the time spent inside
WriteVTKOutputs. Such improvements are proportional to the number of grid outputs (nGridOut) requested, how often they are requested (DTOut), and the number of wake panels used (e.g.,nNWPanels). As an example, running 5 seconds with the above configuration, the total wall-clock time was improved by 5%.For reference, the VTK outputs before and after this change are the same. These changes only impact the computational time. See an example below for illustration purposes:
