You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Draft investigation of Alliance RTSPS video SETUP, following #882. The affected tester still cannot start a session. This is not a verified compatibility fix.
The latest live trace shows the first two relative SETUP forms return 200 with Transport and ping metadata present, but the native parser rejects the video peer. Absolute URI and client-port alternatives return 400. The diagnostic export does not contain the returned field values, so the exact incompatibility remains unknown.
This branch includes:
OpenNOW-Mac’s bounded SETUP candidate ordering, retaining the official first request and requiring a server-provided usable video endpoint. Authentication, session, server and I/O failures stop immediately.
A shared request budget across attempts, with remaining time applied to socket I/O.
Redacted video-setup-transport diagnostics on rejected successful responses. These identify source/port field types, quoting, key spacing, invalid ranges and standard server_port usage. Input is capped at 2 KiB and 16 fields; raw values and unknown names are never logged.
Validation at 2af71f96:
Native streamer workspace: 594 passed, 9 ignored.
Strict core Clippy, formatting and diff checks passed.
Tests cover SETUP ordering and failures, deadlines, diagnostic classifications, secret redaction and output bounds.
Next verification: have the affected Windows tester rebuild fix/alliance-video-setup at 2af71f96 or later, reproduce once, and export diagnostics containing the new video-setup-transport lines. Use that evidence to correct the actual parsing incompatibility before treating this PR as ready.
The latest live test still fails. The new trace shows the first two relative SETUP requests return 200 with Transport and ping metadata present, but video_peer_valid=false; the absolute/client-port alternatives return 400. This points to rejection of the returned Transport data, not failure to find an accepted URI. The exported diagnostics omit the Transport value, so the precise parse failure is not established yet. This PR is not a verified fix for the affected Alliance session despite green CI; investigation needs the actual response from that session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft investigation of Alliance RTSPS video SETUP, following #882. The affected tester still cannot start a session. This is not a verified compatibility fix.
The latest live trace shows the first two relative SETUP forms return 200 with Transport and ping metadata present, but the native parser rejects the video peer. Absolute URI and client-port alternatives return 400. The diagnostic export does not contain the returned field values, so the exact incompatibility remains unknown.
This branch includes:
video-setup-transportdiagnostics on rejected successful responses. These identify source/port field types, quoting, key spacing, invalid ranges and standardserver_portusage. Input is capped at 2 KiB and 16 fields; raw values and unknown names are never logged.Validation at
2af71f96:Next verification: have the affected Windows tester rebuild
fix/alliance-video-setupat2af71f96or later, reproduce once, and export diagnostics containing the newvideo-setup-transportlines. Use that evidence to correct the actual parsing incompatibility before treating this PR as ready.