fix: security dependency updates (golang.org/x/crypto, go-chi, go-jose, mapstructure) - #124
Open
sujit-jadhav wants to merge 3 commits into
Open
fix: security dependency updates (golang.org/x/crypto, go-chi, go-jose, mapstructure)#124sujit-jadhav wants to merge 3 commits into
sujit-jadhav wants to merge 3 commits into
Conversation
- Updated golang.org/x/crypto to v0.54.0 (CVE-2024-45337, CVE-2025-58181, CVE-2026-46595) - Updated golang.org/x/net to v0.56.0 - Updated go-chi/chi/v5 to v5.3.0 (IP spoofing fix in RealIP middleware) - Updated go-jose/go-jose/v4 to v4.1.4 (CVE-2026-34986 JWE decryption panic) - Updated go-viper/mapstructure/v2 to v2.4.0 (CVE-2025-11065 sensitive info leak) Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
middleware.RealIP was deprecated in go-chi/chi v5.3.0 due to IP spoofing vulnerabilities (GHSA-3fxj-6jh8-hvhx, GHSA-rjr7-jggh-pgcp, GHSA-9g5q-2w5x-hmxf). It mutates r.RemoteAddr to the leftmost X-Forwarded-For value regardless of trust. ClientIPFromRemoteAddr stores the client IP from the TCP connection into context (readable via middleware.GetClientIP) without mutating r.RemoteAddr, which is the safe alternative for direct connections. Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
sujit-jadhav
force-pushed
the
fix/security-dependency-updates
branch
from
August 10, 2026 08:33
5a1c4b0 to
b7a4ecb
Compare
Contributor
|
Changes look good, but recent module dep updates are causing conflicts. Can you resolve them and |
Upgrade go-viper/mapstructure/v2 from v2.4.0 to v2.5.0 to resolve the upgrade recommendation for this dependency. Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
synackd
requested changes
Aug 12, 2026
Comment on lines
+8
to
+23
| ## [1.4.9] - 2026-08-11 | ||
|
|
||
| ### Security | ||
|
|
||
| - Updated go-viper/mapstructure/v2 to v2.5.0 (fixes CVE-2025-11065 sensitive info leak) | ||
|
|
||
| ## [1.4.8] - 2026-08-05 | ||
|
|
||
| ### Security | ||
|
|
||
| - Updated golang.org/x/crypto to v0.54.0 (fixes CVE-2024-45337, CVE-2025-58181, CVE-2026-46595) | ||
| - Updated golang.org/x/net to v0.56.0 | ||
| - Updated go-chi/chi/v5 to v5.3.0 (fixes IP spoofing in RealIP middleware) | ||
| - Updated go-jose/go-jose/v4 to v4.1.4 (fixes CVE-2026-34986 JWE decryption panic) | ||
| - Updated go-viper/mapstructure/v2 to v2.5.0 (fixes CVE-2025-11065 sensitive info leak) | ||
|
|
Contributor
There was a problem hiding this comment.
Changes look good, but recent module dep updates are causing conflicts. Can you resolve them and
go mod tidy?
Besides resolving the conflicts by rebasing as mentioned above, let's put the changes under ## Unreleased. We'll worry about setting the version when we tag a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump security-sensitive Go dependencies to address known CVEs.
Changes
Testing
Signed-off-by: Sujit Jadhav sujit.jadhav@dell.com