p2p: recover stream handler panics to avoid node crash - #4706
Open
KaloyanTanev wants to merge 1 commit into
Open
KaloyanTanev wants to merge 1 commit into
KaloyanTanev wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4706 +/- ##
==========================================
- Coverage 65.52% 65.48% -0.04%
==========================================
Files 246 246
Lines 30062 30069 +7
==========================================
- Hits 19698 19691 -7
- Misses 10363 10377 +14
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Recovers panics in the libp2p stream handler goroutine so a malformed peer message can no longer crash the whole process. On a panic the stream is dropped and the node keeps serving; go-libp2p does not recover handler panics itself. Adds a
p2p_message_handler_panics_totalcounter so recovered panics stay visible and alertable.category: bug
ticket: none