Skip to content

app: generate builder config for validator clients - #4704

Draft
KaloyanTanev wants to merge 3 commits into
kalo/proposer-config-filefrom
kalo/builder-config
Draft

KaloyanTanev wants to merge 3 commits into
kalo/proposer-config-filefrom
kalo/builder-config

Conversation

@KaloyanTanev

@KaloyanTanev KaloyanTanev commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Adds gloas builder configuration to the generated VC proposer config file. New charon run flags (--builder-urls, --builder-min-bid, --builder-boost-factor, --builder-max-execution-payment) emit a builder section on the file's default_config: min_bid, builder_boost_factor and max_execution_payment as defaults plus one builders[] entry per URL, with the schema reserving optional per-entry and per-validator overrides for future inputs. Since the values must be identical cluster-wide (they feed signed builder duties post-gloas), each node exposes its config via the app_builder_config_* metrics and gossips a hash of it via peerinfo, warning and setting app_peerinfo_builder_config_mismatch{peer} when a peer diverges.

category: feature
ticket: #4324

@KaloyanTanev KaloyanTanev self-assigned this Sep 17, 2026
@github-actions github-actions Bot added the branch-invalid PR raised against invalid branch. Not a main or release branch. label Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.57%. Comparing base (8330ed0) to head (0b66296).

Files with missing lines Patch % Lines
app/builderconfig.go 58.82% 7 Missing ⚠️
cmd/run.go 61.53% 5 Missing ⚠️
app/app.go 0.00% 3 Missing ⚠️
app/peerinfo/peerinfopb/v1/peerinfo.pb.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           kalo/proposer-config-file    #4704      +/-   ##
=============================================================
+ Coverage                      65.53%   65.57%   +0.03%     
=============================================================
  Files                            247      248       +1     
  Lines                          30158    30216      +58     
=============================================================
+ Hits                           19765    19813      +48     
- Misses                         10392    10402      +10     
  Partials                           1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev mentioned this pull request Sep 17, 2026
58 tasks
@KaloyanTanev
KaloyanTanev force-pushed the kalo/builder-config branch 2 times, most recently from e3b700a to 40e34d7 Compare September 17, 2026 16:55
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-invalid PR raised against invalid branch. Not a main or release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant