Skip to content

*: keep //nolint:revive from nolintlint false autofix - #4703

Open
KaloyanTanev wants to merge 1 commit into
mainfrom
kalo/golangci-keep-revive-nolints
Open

KaloyanTanev wants to merge 1 commit into
mainfrom
kalo/golangci-keep-revive-nolints

Conversation

@KaloyanTanev

Copy link
Copy Markdown
Collaborator

golangci-lint's nolintlint falsely reports //nolint:revive directives as unused and, because the config sets fix: true, silently deletes them on every lint run — even though revive fires on those exact lines without them. This adds a scoped linters.exclusions.rules entry so those directives are neither reported nor auto-removed, while global auto-fixing stays on for everything else. Every falsely-flagged directive in the repo (4 of them) is revive, so the rule is matched to that message.

category: fixbuild
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Sep 16, 2026
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.51%. Comparing base (2ab39d6) to head (1040fb0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4703      +/-   ##
==========================================
- Coverage   65.52%   65.51%   -0.01%     
==========================================
  Files         246      246              
  Lines       30062    30061       -1     
==========================================
- Hits        19698    19695       -3     
- Misses      10363    10365       +2     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant