cmd/exit_sign: warn on validators with pending deposits - #4702
Open
KaloyanTanev wants to merge 1 commit into
Open
KaloyanTanev wants to merge 1 commit into
KaloyanTanev wants to merge 1 commit into
Conversation
|
KaloyanTanev
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4702 +/- ##
=======================================
Coverage 65.52% 65.53%
=======================================
Files 246 246
Lines 30062 30108 +46
=======================================
+ Hits 19698 19730 +32
- Misses 10363 10377 +14
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charon exit sign --allnow warns when a cluster validator has a registered deposit in the beaconpending_depositsqueue but no validator index yet, so no exit could be signed for it — these validators activate later via the queue and were otherwise silently skipped, leading to missed duties after the cluster exited. It also broadens signing to includepending_initializedvalidators, which already have an index and can be pre-signed (harmlessly skipped bybroadcastuntil they activate). Wires the ElectraPendingDepositsbeacon API througheth2wrap. The pending-deposits check is best-effort and never blocks signing exits for the exitable validators.category: bug
ticket: #4701