Skip to content

app: generate proposer config file for validator clients - #4700

Open
KaloyanTanev wants to merge 2 commits into
mainfrom
kalo/proposer-config-file
Open

KaloyanTanev wants to merge 2 commits into
mainfrom
kalo/proposer-config-file

Conversation

@KaloyanTanev

@KaloyanTanev KaloyanTanev commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Generates a proposer-config.json file in a vc-config directory next to the cluster lock on startup: created if missing, never modified afterwards. The file uses a charon-defined canonical schema (version: 1, modelled on the proposer settings format minus its pre-gloas legacy fields): default_config carries the per-field majority fee_recipient and gas_limit across this node's validator shares (from charon's effective builder registrations, including operator overrides, falling back to the lock), and proposer_config only lists validators diverging from it, carrying only the diverging fields. Per validator client adapters (the CDVN wrapper scripts) render each client's native format from it.

From the gloas fork, validator clients sign the fee recipient and gas limit into SignedProposerPreferences, so VCs must be configured with the cluster values instead of relying on charon overriding them (see #4692 for the full design). Generation is best-effort: failures are logged and never prevent duties. Also adds a GasLimit accessor to BuilderRegistrationService and rejects builder registration overrides with a zero gas limit.

category: feature
ticket: #4692

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.63265% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.53%. Comparing base (2ab39d6) to head (8330ed0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/proposerconfig.go 83.33% 13 Missing ⚠️
app/builderregistration.go 78.94% 4 Missing ⚠️
app/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4700      +/-   ##
==========================================
+ Coverage   65.52%   65.53%   +0.01%     
==========================================
  Files         246      247       +1     
  Lines       30062    30158      +96     
==========================================
+ Hits        19698    19765      +67     
- Misses      10363    10392      +29     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev
KaloyanTanev force-pushed the kalo/proposer-config-file branch from 24ac4dc to 7113345 Compare September 16, 2026 14:09
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant