replace ComponentSignals with a "port" abstraction - #570
Merged
Merged
Conversation
Collaborator
|
On my end, this is amazing and helps with readability and clarity. The current implementation on |
superwhiskers
force-pushed
the
sw/scratchpad
branch
12 times, most recently
from
September 9, 2026 17:07
dfa7a95 to
7753126
Compare
superwhiskers
marked this pull request as ready for review
September 9, 2026 17:25
nkoukpaizan
reviewed
Sep 10, 2026
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
A few initial comments.
I like the changes to enum and the behavior of ports.
superwhiskers
force-pushed
the
sw/scratchpad
branch
2 times, most recently
from
September 10, 2026 17:46
ff761d9 to
db8937a
Compare
lukelowry
approved these changes
Sep 10, 2026
lukelowry
left a comment
Collaborator
There was a problem hiding this comment.
Amazing, thank you for this work!
This was referenced Sep 10, 2026
superwhiskers
force-pushed
the
sw/scratchpad
branch
from
September 10, 2026 20:53
db8937a to
f20fe7e
Compare
superwhiskers
force-pushed
the
sw/scratchpad
branch
from
September 11, 2026 18:53
f20fe7e to
b1ca05a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this pull request takes #481 and reworks it to have stronger compile-time checks, in addition to addressing review comments present on it.
i anticipate this pull request needing a lot of discussion before it may be merged. any comments are welcome.
Proposed changes
ComponentSignalswith a "port" abstractionMAXIMUMorSIZEvariant to have their size knownmagic_enumfunctionality in anticipation of it being removable once we use c++26NONEvariants and that their backing type issize_tChecklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
this pull request takes us further in the direction of compile-time enforcement. most of the changes relative to #481 were made to achieve this.