#4458 executive summary schema changes - #4461
Open
staysgt wants to merge 9 commits into
Open
Conversation
staysgt
force-pushed
the
#4458-executive-summary-schema-changes
branch
from
September 11, 2026 22:06
6960c15 to
8d66e8b
Compare
staysgt
marked this pull request as ready for review
September 12, 2026 00:56
wavehassman
requested changes
Sep 13, 2026
| organization Organization @relation(fields: [organizationId], references: [organizationId]) | ||
| seasonName String | ||
| seasonStartDate DateTime | ||
| seasonEndDate DateTime |
Contributor
There was a problem hiding this comment.
where are these 3 used?
I feel like we should just link this to car since each car is a new season
Contributor
Author
There was a problem hiding this comment.
I linked a car and got rid of the season name, but kept the seasonStartDate/endDate; I think those fields would be needed for calculating for some of the graphs. For example, the getBudgetSummary ticket needs to filter by dates. Maybe we could also have it just default like Aug-Aug, or whenever a season may actually run. Or the start/end date could also be attached to the car, which may make more sense
wavehassman
requested changes
Sep 13, 2026
wavehassman
requested changes
Sep 13, 2026
wavehassman
requested changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Schema changes, shared types, and seed data for executive summary dashboard.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4458