#4408-schema-changes - #4456
#4408-schema-changes#4456
Conversation
| @@ -0,0 +1,7 @@ | |||
| -- AlterTable | |||
| ALTER TABLE "Change_Request" ADD COLUMN "snapshotBlockingCount" INTEGER, | |||
| ADD COLUMN "snapshotDuration" INTEGER, | |||
There was a problem hiding this comment.
Could we not pull the duration and start date from the wbs element associated with the change request if the CR is not changing count or duration? If it is changing count or duration, shouldn't that be listed in the proposed changes or activation cr?
There was a problem hiding this comment.
Yeah, I think the issue is more that we need the start date/duration from when the CR was created, not whatever the WBS element has later.
Like if an Activation CR changes a WP startDate from Sept 1 → Sept 15, once it gets approved reviewActivationChangeRequest updates Work_Package.startDate to Sept 15. So if we pull it from the WBS element after that, we’ve lost the Sept 1 value. The proposed changes / Activation_CR only has the new value too, so that wouldn’t give us the original one.
And then for CRs that aren’t changing start date or duration, like Budget or most Standard CRs, we still need those values for the triage score. So I think we need to save them on the CR when it’s created so they stay tied to that point in time. Let me know your thoughts.
| wbsProposedChangesId String? @unique | ||
| wbsProposedChanges Wbs_Proposed_Changes? @relation("wbsProposedChanges", fields: [wbsProposedChangesId], references: [wbsProposedChangesId]) | ||
| snapshotBlockingCount Int? | ||
| snapshotStartDate DateTime? |
There was a problem hiding this comment.
this should prob be db.Date
2 participants
Changes
Just adding an activationBufferDays to Organization in schema also snapshot fields for cr and timelineChangeFromUnmarkedBlocker for work package proposed changes.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4409