Skip to content

#4346: Clear form state only on cancel - #4436

Open
vijayab2029 wants to merge 1 commit into
developfrom
#4346-clear-form-state-only-on-cancel
Open

#4346: Clear form state only on cancel#4436
vijayab2029 wants to merge 1 commit into
developfrom
#4346-clear-form-state-only-on-cancel

Conversation

@vijayab2029

@vijayab2029 vijayab2029 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Changes

_Fixed NERModal by preventing closing when clicked outside of the modal itself. Now form state does not change unless cancel is clicked explicitly. _

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@Santiordon Santiordon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@wavehassman wavehassman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following modals do not use this component, so they will need to be fixed in their file:

  • Import BOM Modal
  • Add Gantt Selection Modal
  • Edit Series Confirmation Modal
  • Delete Series Confirmation Modal
  • Schedule Event Modal
  • Change Request Blocker Warning
  • Review Change Request View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants