Stop emailing everyone on every plugin approval

[simonhamp]

What

New plugin announcements are now in-app only — no email.

• NewPluginAvailable::via() returns ['database'] instead of ['mail', 'database'].
• Added a sortable Approved (approved_at) column to the admin Plugins table, next to Submitted.

Why

We were emailing the entire opted-in user base once per plugin, every time a plugin was approved. At the rate plugins are landing that's far too much mail for something that isn't urgent.

The notification itself is still useful, so it stays — it just arrives in the UI rather than the inbox.

Behaviour

	Before	After
Plugin author	PluginApproved email	unchanged
Opted-in users	NewPluginAvailable email + in-app	in-app only
Opted-out users	nothing	nothing

Plugin::approve() is unchanged — it still dispatches SendNewPluginNotifications on first approval, so the fan-out and its "skip the author" / "verified emails only" rules all still apply. The only difference is which channel the notification resolves to.

The "New plugin notifications" toggle in user settings still silences it completely, so the preference remains meaningful.

Sorting by approval date

The admin Plugins table gets a sortable Approved column (rows with no approval show -), so recently approved plugins are easy to pull up now that they aren't announcing themselves by email.

Two things reviewers should weigh in on

1. NewPluginAvailable::toMail() is now unreachable. I left the method (and its three mail-content tests) in place rather than deleting it — restoring the email is a one-line change to via() if we decide this went too far. Happy to strip it if we'd rather not carry dead code.
2. plugins:resend-new-plugin-notifications no longer sends email. That command exists to re-send NewPluginAvailable, so it now only re-adds in-app notifications — largely pointless in its current form. If we want to keep a manual "email people about a batch of new plugins" escape hatch, it needs its own notification class; it can't share this one any more.

Tests

• test_via_returns_database_only_when_user_opted_in — updated assertion.
• test_via_never_includes_the_mail_channel — new regression guard so the email can't quietly come back.
• test_plugins_table_can_be_sorted_by_approved_at — covers the new column in both directions.
• The dispatch, job, and resend-command tests are untouched and still pass, since those paths are unchanged.

Note the three existing toMail() tests still pass but now cover an unreachable method — they'd go along with the method if we strip it.

🤖 Generated with Claude Code