Degrade view transitions under Reduce Motion - #72
Open
shanerbaner82 wants to merge 1 commit into
Open
Conversation
`view_transition` was reaching the renderer untouched when Reduce Motion is on. Substituting a plain fade drops the shared-element morph along with the directional motion, since the morph IS the movement that setting asks us not to make. `none` and `fade` are already motionless and still pass through. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to NativePHP/mobile-air#372, which adds shared-element view
transitions (
ref+@navigate.viewTransition).The
NativeUI.Transition.Setbridge function is where Reduce Motion is honoured— it already substitutes a plain fade for anything that isn't
noneorfade.The new
view_transitionvalue was reaching the renderer untouched.Substituting a fade drops the shared-element morph along with the directional
motion, which is correct: the morph is the movement that setting asks us not
to make.
noneandfadeare already motionless and still pass throughunchanged.
Three lines plus a comment. Safe to merge before or after the core PR — until
core ships,
view_transitionis simply a value nothing emits.🤖 Generated with Claude Code