fix: Android images default to Fit when no object-* class is set - #63
Open
SRWieZ wants to merge 1 commit into
Open
fix: Android images default to Fit when no object-* class is set#63SRWieZ wants to merge 1 commit into
SRWieZ wants to merge 1 commit into
Conversation
SRWieZ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
native:imagewithout anobject-*class renders differently on each platform. The PHPImageelement only emitsfitwhen one is set, and the renderers disagree on the missing-prop default:resolveContentMode(0)→.fitp.getInt("fit")→0→ContentScale.NoneOn Android the bitmap is painted at intrinsic size and center-cropped to the frame. A 1024×1024 logo in a
w-10 h-10box shows only a 40 dp patch from its middle.Fix
p.getInt("fit", 1)— a missing prop now defaults to Fit, matching iOS. An explicitobject-nonestill sendsfit: 0and keepsContentScale.None; the other mappings are unchanged.