Sync the vendored RAPIDS.cmake with rapids-cmake release/25.12 - #466
Open
MaxFreedomPollard wants to merge 1 commit into
Open
MaxFreedomPollard wants to merge 1 commit into
MaxFreedomPollard wants to merge 1 commit into
Conversation
The vendored copy still defaulted to the branch-XX.YY naming. rapids-cmake has since moved its release branches to release/XX.YY, and GitHub now redirects branch-25.12 to main. NVBench therefore fetched rapids-cmake main instead of 25.12, and main requires CMake 4.0, so configuring with the documented CMake 3.30.4 or any 3.x failed. The release/25.12 copy of RAPIDS.cmake defaults to release/XX.YY. It differs from the vendored one only in that line and in the license header. Fixes NVIDIA#465
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #465.
Configuring with any CMake 3.x currently fails, although the README and
cmake_minimum_requiredsay 3.30.4:The vendored
cmake/RAPIDS.cmaketurns the requested version into the branch namebranch-25.12. rapids-cmake has moved its release branches torelease/XX.YY, and GitHub now redirectsbranch-25.12tomain: the archive URL answers with a 302 to.../zip/main. So NVBench has been building against rapids-cmakemainrather than 25.12, andmainrequires CMake 4.0.rapids-cmake's own
release/25.12copy ofRAPIDS.cmakealready defaults torelease/${rapids-cmake-version}. It differs from the vendored file only in that line and in the license header, so this syncs the vendored copy with it. I also updated the download URL in the comment inNVBenchRapidsCMake.cmake, which pointed at the old branch name.Testing
In
nvidia/cuda:12.9.1-devel-ubuntu24.04with CMake 3.31.10 and-DCMAKE_CUDA_ARCHITECTURES=90(no GPU):nvbenchtarget builds and linksConfiguring with CMake 4.3.2 gets past rapids-cmake as well, so newer CMake is not affected.