Skip to content

Jitify should not print warnings to stdout by default #79

Description

@harrism

Jitify prints logs to stdout by default because JITIFY_PRINT_LOG is defined to 1 by default.

jitify/jitify.hpp

Lines 2817 to 2821 in 3e96bcc

#if JITIFY_PRINT_LOG
std::cout << include_parent << "(" << line_num
<< "): warning: " << include_name << ": [jitify] File not found"
<< std::endl;
#endif

I think it really should print warnings and errors to stderr by default, and ideally provide a way to override logs so they can be output to a file if desired.

See NVIDIA/cudf#6117

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions