[REVIEW] Lucene upgrade to 10.4 in cuvs-lucene - #2586
Open
punAhuja wants to merge 2 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Hi @punAhuja, thank you very much for your contribution. Unfortunately, simply moving to Lucene 10.4.0 won't work for us. Some of our users will need to remain on Lucene 10.2 for the foreseeable future because of third-party dependencies, while other platforms are eager to move to 10.5. We need a more comprehensive solution that targets multiple Lucene versions at once. Enabling support for newer versions of Lucene is very high on our priority list and we are actively working on this at the moment. Thanks again for the patience and the effort here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solr 11 supports lucene 10.4, so the current cuvs artefacts (which have lucene 10.2) don't work with solr due to lucene version mismatch.
cuvs-lucenefrom Lucene 10.2.0 to 10.4.0.AcceptDocs, write HNSW graphs with GroupVarInt, and delegate codecs toLucene104Codec(float HNSW remains lucene99).LuceneProviderso99and104instances are cached separately.