Add timeouts to Python test runs - #2577
Open
bdice wants to merge 2 commits into
Open
Conversation
bdice
changed the title
bdice
added
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a 40-minute timeout to each Python pytest invocation, followed by a forced kill after a one-minute grace period.
This prevents a wedged Python/GPU test process from consuming the full six-hour CI limit, as occurred in https://github.com/NVIDIA/cuvs/actions/runs/34318536549/job/102387735874.
Across the five most recent workflow executions where all Python test configurations passed, the slowest complete Python job took 28m13s and its Python tests step took 27m10s. A 40-minute test timeout leaves reasonable headroom for normal runtime variation.