[Common] Group NVFP4 Quantize Kernels - #3458
Open
Oleg-Goncharov wants to merge 7 commits into
Open
Conversation
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Contributor
Greptile SummaryThis PR adds grouped BF16-to-NVFP4 quantization with optional transposed output and shared scaling logic.
Confidence Score: 5/5The PR appears safe to merge because the previously reported quantization dispatch regression is fixed at current HEAD. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
API[nvte_group_quantize] --> Dispatch[Scaling-mode dispatch]
Dispatch --> NVFP4[Grouped NVFP4 kernel]
NVFP4 --> Layout[Shape-specific work mapping]
Layout --> Row[Rowwise FP4 output and scales]
Layout --> Col[Optional transposed FP4 output and scales]
Reviews (4): Last reviewed commit: "Merge branch 'main' into pr_nvfp4_group_..." | Re-trigger Greptile |
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Oleg-Goncharov
force-pushed
the
pr_nvfp4_group_kernels
branch
from
September 1, 2026 20:48
71dd22f to
2fdd9c3
Compare
for more information, see https://pre-commit.ci
Collaborator
Author
|
/te-ci |
Collaborator
Author
|
/te-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds optimized grouped NVFP4 1D quantization support for BF16 grouped tensors.
The implementation enables grouped and MoE-style workloads to quantize multiple tensors with different shapes without launching the existing NVFP4 kernel separately for each tensor. It supports rowwise NVFP4 output together with an optional transposed columnwise output and the corresponding scaling factors.
All four grouped tensor shape representations are supported:
SAME_BOTH_DIMSVARYING_FIRST_DIMVARYING_LAST_DIMVARYING_BOTH_DIMSType of change
Changes
nvte_group_quantize.amaxvalues and compact E4M3 scaling factors.ShapeRepresentationlayouts.DefaultCastConfigand shape-specificCastConfigspecializations, allowing kernel parameters to be tuned independently for each grouped layout.Checklist: