fix: inspect TypeScript declaration content - #601
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #585 by distinguishing clearly inert TypeScript declaration files from executable TypeScript based on their content, while keeping uncertain files executable.
Changes
.d.ts,.d.cts, and.d.mtsdeclaration names only when their UTF-8 content is clearly declaration-only.require()payload hidden behind a.d.ctsname.Testing
uv run pytest tests/nodes/test_nested_artifacts.py -q— 47 passed, 1 warning.uv run ruff check src/ tests/— passed.uv run ruff format --check src/ tests/— passed.git diff --check— passed.uv run pytest -m 'not integration and not provider' tests/ -q— started successfully and reached 61% before being interrupted after several minutes; no failures were reported before interruption.Notes
The implementation is intentionally fail-closed: declaration filenames alone never suppress executable classification. This PR was prepared with AI assistance; I reviewed the change and take responsibility for the submitted code.