test: make Basic auth fixture explicitly synthetic - #600
Merged
Merged
Conversation
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
marked this pull request as ready for review
September 21, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provenance redaction test contains a literal encoded HTTP Basic authentication header that triggers secret scanning despite being test data. Build the header from explicit synthetic credentials at runtime and give the case a stable
synthetic-basic-authpytest ID. This preserves the existing redaction assertions and keeps the encoded value out of normal pytest case names.This is a test-fixture cleanup. Production sanitization and authentication behavior are unchanged. Historical secret-scanning alerts still require a separate “Used in tests” resolution.
Validation:
PYTHONPATH=src python -m pytest -q tests/unit/test_llm_provenance.py— 36 passed (Python 3.12).python -m ruff check src/ tests/— passed.python -m ruff format --check src/ tests/— passed, 229 files.git diff --check— passed.