Skip to content

ci: trigger package portability for Rust build configuration - #678

Merged
ayushag-nv merged 1 commit into
mainfrom
codex/ci-portability-rust-config-triggers
Sep 11, 2026
Merged

ci: trigger package portability for Rust build configuration#678
ayushag-nv merged 1 commit into
mainfrom
codex/ci-portability-rust-config-triggers

Conversation

@afourniernv

@afourniernv afourniernv commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What

Run Package Portability when rust-toolchain.toml or .cargo/config.toml changes.

Why

Both files affect the Linux wheel build, but neither currently triggers the workflow. A Rust toolchain or target flag change can therefore reach main without rebuilding and smoke-testing the wheel.

How tested

  • go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 .github/workflows/package-portability.yml
  • Parsed the workflow with Ruby/Psych and verified both paths under the pull request and main-push filters
  • git diff --check
  • Commit carries the required DCO sign-off

Notes for reviewers

This only changes when Package Portability runs. The wheel build, test commands, package configuration, release workflow, artifacts, and publishing behavior are unchanged.

Summary by CodeRabbit

  • Chores
    • Portability checks now run when Rust toolchain or Cargo configuration changes are submitted for review or pushed to the main branch.

Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv requested a review from a team as a code owner September 10, 2026 20:55
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cbc67499-4ca7-45f8-9741-8d02a0189957

📥 Commits

Reviewing files that changed from the base of the PR and between a70a1fb and 17038bb.

📒 Files selected for processing (1)
  • .github/workflows/package-portability.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review.


Walkthrough

The package portability workflow now triggers when rust-toolchain.toml or .cargo/config.toml changes in pull requests and pushes to main.

Changes

Package portability workflow

Layer / File(s) Summary
Workflow path filters
.github/workflows/package-portability.yml
The pull-request and push filters include rust-toolchain.toml and .cargo/config.toml.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 17038

Rust and Cargo configuration changes will now run package portability checks for pull requests and pushes to main. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the workflow trigger change for Rust build configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

A rabbit checks the Rusty gate
Two config paths now wake it straight
Pull requests hop, pushes run
Toolchain changes meet the sun
Portability work is done

Comment @coderabbitai help to get the list of available commands.

@afourniernv

Copy link
Copy Markdown
Contributor Author

For reference, Relay includes rust-toolchain.toml in its Rust package path filter, so Rust toolchain changes run package CI there too.

Relay does not currently have a .cargo/config.toml; that path is specific to Switchyard because ours sets the Linux target flags used by the wheel build.

@ayushag-nv ayushag-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ayushag-nv
ayushag-nv merged commit b0257cb into main Sep 11, 2026
17 checks passed
@ayushag-nv
ayushag-nv deleted the codex/ci-portability-rust-config-triggers branch September 11, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants