ci: lint GitHub Actions workflows - #677
Conversation
f275765 to
c870f38
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review. WalkthroughThe pull request adds an ChangesActionlint validation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change adds workflow linting without altering runtime, packaging, or release behavior and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
A rabbit checks each workflow line Comment |
ayushag-nv
left a comment
There was a problem hiding this comment.
Looks good and relevant. Please rebase and merge
Signed-off-by: Alex Fournier <afournier@nvidia.com>
c870f38 to
07f258b
Compare
What
Adds
actionlintto pre-commit and runs the same pinned hook in the existing CI lint job.The first GitHub run also found two unquoted variables in
perf.yml; those are quoted so the current workflow set starts clean.Why
Workflow YAML can parse successfully while still containing invalid GitHub expressions, contexts, matrix references, job dependencies, or embedded shell. This catches those errors before a workflow is merged.
How tested
uvx --from pre-commit==4.5.0 pre-commit validate-configuvx --from pre-commit==4.5.0 pre-commit run actionlint --all-files— all 9 workflows passedLintjob — actionlint,uv sync, and Ruff passed on Ubuntu 24.04git diff --checkNotes for reviewers
This uses the same
actionlinthook and version as NeMo Relay without copying its larger pre-commit CI setup. It adds no new GitHubuses:reference, public API, dependency lock change, packaging, or release behavior.