Skip to content

ci: lint GitHub Actions workflows - #677

Merged
afourniernv merged 1 commit into
NVIDIA-NeMo:mainfrom
afourniernv:codex/actionlint-ci
Sep 11, 2026
Merged

ci: lint GitHub Actions workflows#677
afourniernv merged 1 commit into
NVIDIA-NeMo:mainfrom
afourniernv:codex/actionlint-ci

Conversation

@afourniernv

@afourniernv afourniernv commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What

Adds actionlint to pre-commit and runs the same pinned hook in the existing CI lint job.

The first GitHub run also found two unquoted variables in perf.yml; those are quoted so the current workflow set starts clean.

Why

Workflow YAML can parse successfully while still containing invalid GitHub expressions, contexts, matrix references, job dependencies, or embedded shell. This catches those errors before a workflow is merged.

How tested

  • uvx --from pre-commit==4.5.0 pre-commit validate-config
  • uvx --from pre-commit==4.5.0 pre-commit run actionlint --all-files — all 9 workflows passed
  • GitHub Actions Lint job — actionlint, uv sync, and Ruff passed on Ubuntu 24.04
  • git diff --check
  • Commit carries the required DCO sign-off

Notes for reviewers

This uses the same actionlint hook and version as NeMo Relay without copying its larger pre-commit CI setup. It adds no new GitHub uses: reference, public API, dependency lock change, packaging, or release behavior.

@afourniernv
afourniernv requested a review from a team as a code owner September 10, 2026 20:37
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d46f2abd-bbf2-4e08-8a12-a451055eea30

📥 Commits

Reviewing files that changed from the base of the PR and between cb98af0 and f275765.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .pre-commit-config.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


Walkthrough

The pull request adds an actionlint pre-commit hook and runs it in the CI lint job. The lint job display name changes from Lint (ruff) to Lint.

Changes

Actionlint validation

Layer / File(s) Summary
Configure actionlint validation
.pre-commit-config.yaml, .github/workflows/ci.yml
The pre-commit configuration adds actionlint at v1.7.12. The CI lint job runs the pinned hook across all files and uses the display name Lint.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to f2757

This change adds workflow linting without altering runtime, packaging, or release behavior and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding linting for GitHub Actions workflows in CI.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

A rabbit checks each workflow line
Actionlint guards the morning run
Pre-commit hops into place
CI follows with steady pace
Clean checks greet the day

Comment @coderabbitai help to get the list of available commands.

@ayushag-nv ayushag-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and relevant. Please rebase and merge

Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv merged commit 2806a81 into NVIDIA-NeMo:main Sep 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants